mrpollo

PX4 CI Orchestrator Analysis: PR #26257

Date: 2026-02-13 | Branch: mrpollo/ci_orchestration | PR: PX4/PX4-Autopilot#26257

---

PR Review Status

• dagar (Matthias): Has NOT commented on this PR at all. Not in timeline.
• MaEtUgR (Matthias Grob): Posted today with two key concerns:

mrpollo

PX4 CI Orchestrator Cost Report

Summary

Analyzed 20 workflow runs of the ci-orchestrator.yml workflow on PX4/PX4-Autopilot (branch mrpollo/ci_orchestration), spanning Jan 13 - Feb 13, 2026.

Data source: RunsOn show_costs: inline post-job output from each job's logs, GitHub Actions job timestamps, and GitHub-hosted runner pricing.

Note: PX4-Autopilot is a public open-source repository. GitHub provides free GitHub Actions minutes for public repos, so the macOS and Ubuntu GitHub-hosted runner jobs have $0 actual cost to the project. The "GitHub equivalent" costs shown are what these would cost on a private repository for reference. The only real costs are the RunsOn (AWS) self-hosted runner charges.

mrpollo

"Review as Dagar" Checklist

When asked to "review as dagar" or "review like dagar", adopt the review style of Daniel Agar (@dagar), principal maintainer of PX4-Autopilot. This checklist was synthesized from analyzing 200 of his actual PR reviews.

Review Priorities (in order)

1. Architecture & Module Boundaries

• Does the code live in the module that naturally owns the data/logic?
• Are there unnecessary cross-module dependencies? (e.g., commander importing EKF2 params)
• Should this be parameter-driven config instead of compile-time?

mrpollo

@dagar PR Review Pattern Analysis

Methodology

• Repository: PX4/PX4-Autopilot
• Reviewer: @dagar (Daniel Agar)
• Total PRs sampled: 200 (from a pool of 3,762 reviewed PRs)
• PRs with substantive comments: 99 out of 200 (49.5%)
• PR number range: #24002 - #25887 (spanning ~1.5 years of reviews)
• Data source: GitHub API - PR review comments, inline comments, and issue comments

mrpollo

#!/usr/bin/env python3
"""
Test FlightTaskOrbit via MAVSDK on PX4 SITL with SIH.
Verifies that orbit mode activates and the vehicle flies a circular path.
"""

import asyncio
import math
import sys
from mavsdk import System

mrpollo

" ~/.vimrc -- @mrpollo's Vim configuration

" show line numbers
set number
set relativenumber

" show ruler (line and column numbers in the status line)
set ruler

" disable line wrapping per buffer (you can still toggle with :set wrap)

mrpollo

PYTHON_VERSION=$(python3 --version 2>&1 | awk '{print $2}')
REQUIRED_VERSION="3.11"
if [[ "$(printf '%s\n' "$REQUIRED_VERSION" "$PYTHON_VERSION" | sort -V | head -n1)" == "$REQUIRED_VERSION" ]]; then
	python3 -m pip install --break-system-packages -r ${DIR}/requirements.txt
else
	if [ -n "$VIRTUAL_ENV" ]; then
		# virtual environments don't allow --user option
		python -m pip install -r ${DIR}/requirements.txt
	else
		python3 -m pip install --user -r ${DIR}/requirements.txt

mrpollo

v1.11.0-beta2 (2020-05-10)

ADC

• replace ioctl with uorb message (#14087)

ATTITUDE_QUATERNION

mrpollo

Changelog

v1.10.0-beta4 (2019-10-21)

CollisionPrevention

• remove unnecessary double precision floating point math

mrpollo

from __future__ import print_function
from flask import Flask, request
from dronekit import connect, LocationGlobal, VehicleMode
import sys, time

class Drone(object):
    def __init__(self):
        self.vehicle = connect('tcp:127.0.0.1:5760', wait_ready=True)
        self.vehicle.add_attribute_listener('armed', self._armed_callback)