Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Select an option

  • Save llelectronics/2528d9918169f81fdefc854718e7db9f to your computer and use it in GitHub Desktop.

Select an option

Save llelectronics/2528d9918169f81fdefc854718e7db9f to your computer and use it in GitHub Desktop.
Git Diff
From b5a06939c75489a10f9068c7cbe57ba8ecd071c5 Mon Sep 17 00:00:00 2001
From: Leszek Lesner <leszek.lsner@web.de>
Date: Wed, 6 Sep 2017 23:35:04 +0200
Subject: [PATCH] Add proper full screen support
---
.../Source/WebKit2/UIProcess/qt/QtPageClient.cpp | 17 +++++++++++++++--
.../Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.h | 1 +
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/qtwebkit-5.212.0-alpha2/Source/WebKit2/UIProcess/qt/QtPageClient.cpp b/qtwebkit-5.212.0-alpha2/Source/WebKit2/UIProcess/qt/QtPageClient.cpp
index 372d8c6..45966c5 100644
--- a/qtwebkit-5.212.0-alpha2/Source/WebKit2/UIProcess/qt/QtPageClient.cpp
+++ b/qtwebkit-5.212.0-alpha2/Source/WebKit2/UIProcess/qt/QtPageClient.cpp
@@ -298,12 +298,25 @@ bool QtPageClient::isFullScreen()
void QtPageClient::enterFullScreen()
{
- notImplemented();
+ if (!m_webView)
+ return;
+
+ WebFullScreenManagerProxy* manager = m_eventHandler->webPageProxy()->fullScreenManager();
+ manager->willEnterFullScreen();
+#if HAVE(QTQUICK)
+ emit m_webView->experimental()->enterFullScreenRequested();
+#endif
+ manager->didEnterFullScreen();
}
void QtPageClient::exitFullScreen()
{
- notImplemented();
+ WebFullScreenManagerProxy* manager = m_eventHandler->webPageProxy()->fullScreenManager();
+ manager->willExitFullScreen();
+#if HAVE(QTQUICK)
+ emit m_webView->experimental()->exitFullScreenRequested();
+#endif
+ manager->didExitFullScreen();
}
void QtPageClient::beganEnterFullScreen(const IntRect& initialFrame, const IntRect& finalFrame)
diff --git a/qtwebkit-5.212.0-alpha2/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.h b/qtwebkit-5.212.0-alpha2/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.h
index 2fe82e8..32c7f3f 100644
--- a/qtwebkit-5.212.0-alpha2/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.h
+++ b/qtwebkit-5.212.0-alpha2/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.h
@@ -93,6 +93,7 @@ public:
void resetGestureRecognizers();
PageViewportControllerClientQt* viewportController() { return m_viewportController; }
+ WebPageProxy* webPageProxy() { return m_webPageProxy; }
void startDrag(const WebCore::DragData&, PassRefPtr<ShareableBitmap> dragImage);
--
1.9.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment