florianbachmann

#import <Foundation/Foundation.h>
#include <dlfcn.h>

NSDictionary *FCPrivateBatteryStatus()
{
    static mach_port_t *s_kIOMasterPortDefault;
    static kern_return_t (*s_IORegistryEntryCreateCFProperties)(mach_port_t entry, CFMutableDictionaryRef *properties, CFAllocatorRef allocator, UInt32 options);
    static mach_port_t (*s_IOServiceGetMatchingService)(mach_port_t masterPort, CFDictionaryRef matching CF_RELEASES_ARGUMENT);
    static CFMutableDictionaryRef (*s_IOServiceMatching)(const char *name);

florianbachmann

How to do codereview

Step 1: Context

Check what should have been done

Step 2: Git Changes

Check the related git commit

Step 3: Syntax Check

Check if the Dev use the right syntax and follow the styleguide

florianbachmann

// Use Gists to store code you would like to remember later on
console.log(window); // log the "window" object to the console

florianbachmann

// config.js
module.exports = {
  dev: {
    dbname: 'foo',
    host: '127.0.0.1',
    pass: 'bar',
    port: 1223
  },
  prod: {
    dbname: 'baz',

florianbachmann

100	Keynote
101	Platforms State of the Union
102	Apple Design Awards
109	Painting the Future
200	Accessibility in OS X
201	Building User Interfaces for iOS 7
202	Accessibility in iOS
203	What’s New in Cocoa Touch
204	What’s New with Multitasking
205	What’s New in Cocoa

florianbachmann

sys_rb_usr=/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr
sdk_rb_usr=`xcode-select -p`/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr
sudo cp -r $sdk_rb_usr/include $sys_rb_usr/include

florianbachmann

#define $(...) \
    ({ \
        __weak __typeof__(self) weakSelf = self; \
        \
        ^(__VA_ARGS__) { \
            __strong __typeof__(weakSelf) self = weakSelf; \
            $_body_

#define $_body_(...) \
            __VA_ARGS__ \

florianbachmann

@interface SomeViewController ()

// Declare some collection properties to hold the various updates we might get from the NSFetchedResultsControllerDelegate
@property (nonatomic, strong) NSMutableIndexSet *deletedSectionIndexes;
@property (nonatomic, strong) NSMutableIndexSet *insertedSectionIndexes;
@property (nonatomic, strong) NSMutableArray *deletedRowIndexPaths;
@property (nonatomic, strong) NSMutableArray *insertedRowIndexPaths;
@property (nonatomic, strong) NSMutableArray *updatedRowIndexPaths;

@end

florianbachmann

//
//  CCamera.h
//  CCamera
//
//  Created by Jonathan Wight on 7/12/12.
//  Copyright (c) 2012 Jonathan Wight. All rights reserved.
//

#import <Foundation/Foundation.h>

florianbachmann

input = ARGV[0]
episode = ARGV[1]
unless input and episode
  puts 'Usage: convert.rb Episode003-master.mov 003'
  exit
end

# Config
threads = 4
qmin = 10