chertov

План устранения замечаний по ревью PromQL (metrics-promql)

Дата: 2025-12-25
Источники: review_claude.md, review_codex.md, review_gemini.md

Контекст и цель

promql/ — Rust-реализация PromQL (AST + парсер + in-memory eval), проверяемая вендоренным корпусом Prometheus promqltest.

Текущее состояние: promqltest проходит полностью (full eval).

chertov

# ```Mikrotik
# /system scheduler add name="checkSMS" on-event=smsToTelegram interval=10s 
# ```

# smsToTelegram script

:local botToken "1111111111:AAA-A-AAAAAAAAAAAA-AAAAAAAAAAAAAAAA";
:local chatId "11111111";
:local totalSMS [/tool sms inbox print count-only];

chertov

#!/bin/bash
set -e

script_path="$( cd "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )/"
echo script_path: ${script_path}

brew install openssl@1.1 libxml2 qt@6 postgresql@15 libpq

# export QT_ROOT=/opt/homebrew/Cellar/qt/6.5.2
export QT_ROOT=/Users/user/Qt/6.5.3/macos/

chertov

req: { "Name" : "General.General", "SessionID" : "0x00000070" }
res: { "General.General" : { "AutoLogout" : 0, "FontSize" : 24, "IranCalendarEnable" : 0, "LocalNo" : 0, "MachineName" : "LocalHost", "OverWrite" : "OverWrite", "ScreenAutoShutdown" : 10, "ScreenSaveTime" : 0, "VideoOutPut" : "Auto" }, "Name" : "General.General", "Ret" : 100, "SessionID" : "0x00000070" }

req: { "Name" : "General.Location", "SessionID" : "0x00000070" }
res: { "General.Location" : { "DSTEnd" : { "Day" : 1, "Hour" : 1, "Minute" : 1, "Month" : 10, "Week" : 0, "Year" : 2023 }, "DSTRule" : "Off", "DSTStart" : { "Day" : 1, "Hour" : 1, "Minute" : 1, "Month" : 5, "Week" : 0, "Year" : 2023 }, "DateFormat" : "YYMMDD", "DateSeparator" : "-", "IranCalendar" : 0, "Language" : "English", "TimeFormat" : "24", "VideoFormat" : "NTSC", "Week" : null, "WorkDay" : 62 }, "Name" : "General.Location", "Ret" : 100, "SessionID" : "0x00000070" }

req: { "Name" : "OPTimeQuery", "SessionID" : "0x00000070" }
res: { "OPTimeQuery" : "2023-08-01 00:19:07", "Re

chertov

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
Starting periodic command scheduler: cron.
Starting enhanced syslogd: rsyslogdrsyslogd: imklog: cannot open kernel log (/proc/kmsg): Operation not permitted.
rsyslogd: activation of module imklog failed [v8.2102.0 try https://www.rsyslog.com/e/2145 ]
.
KiKiMR start failed
Traceback (most recent call last):
  File "ydb/tests/library/harness/kikimr_runner.py", line 272, in start
    self.__run()
  File "ydb/tests/library/harness/kikimr_runner.py", line 292, in __run

chertov

use std::sync::Arc;
use parking_lot::RwLock;
use std::collections::VecDeque;

use log::trace;
use anyhow::anyhow;

struct Thread {
    thread_handler: std::thread::JoinHandle<()>,
    running: Arc<RwLock<bool>>,

chertov

# tarantool: '{ git = "https://github.com/chertov/tarantool-module.git", branch = "dev", features=["schema"] }'
# tarantool: '{ path = "/Users/user/dev/tarantool-module/tarantool", features=["schema"] }'
tarantool_schema: '{ git = "https://github.com/chertov/tarantool-schema.git" }'

# dependencies:
#    bb_proto: '{ path = "./../../../bb_proto", features = ["tnt"] }'

spaces:
    users:
        engine: 'memtx'

chertov

// коллбеки на все найденые тесты в нашем проекте
type TestFunction = fn() -> Result<(), anyhow::Error>;

// глобальный лист всех найденных тестов, который сформируется при загрузке библиотеки в тарантул
static TESTS: once_cell::sync::Lazy<parking_lot::RwLock<std::collections::HashMap<String, TestFunction>>> = 
once_cell::sync::Lazy::new(|| {
    parking_lot::RwLock::new(std::collections::HashMap::new())
});

// для нашего теста fn test1 процедурный макрос атрибут tnt_test сегенерирует следующую функцию

chertov

use tarantool::index::{ IndexType, IndexOptions, IndexPart, IndexFieldType, IteratorType };
use tarantool::space::{ Space, SpaceCreateOptions, SpaceFieldFormat, SpaceFieldType };
use tarantool::tuple::{ AsTuple, Tuple };

pub const SPACE_NAME: &str = "pubsub";

const INDEX__ID: &str = "id";
const INDEX__TO: &str = "to";
const INDEX__CRATED_AT: &str = "crated_at";

chertov

#!/bin/bash

export GITHUB_TOKEN=<YOUR GITHUB TOKEN>

USER=<YOUR USERNAME>
WEBRTC_RS=webrtc-rs

# brew install gh
gh repo list ${WEBRTC_RS}