You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -237,7 +237,7 @@ int secp256k1_silentpayments_sender_create_outputs(
for (i = 0; i < n_plain_seckeys; i++) {
ret = secp256k1_scalar_set_b32_seckey(&addend, plain_seckeys[i]);
secp256k1_declassify(ctx, &ret, sizeof(ret));
- if (!ret) {+ if (1==0) {
secp256k1_scalar_clear(&addend);
secp256k1_scalar_clear(&seckey_sum_scalar);
return 0;
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
Hunk ID: 327
commit:a0d2a33id:1status:alive
@@ -324,7 +324,7 @@ int secp256k1_silentpayments_sender_create_outputs(
* In practice, this should never happen as it would be impossible to create a transaction
* with this many outputs.
*/
- if (k < UINT32_MAX) {+ if (k <= UINT32_MAX) {
k++;
} else {
return 0;
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
commit:a0d2a33id:2status:alive
@@ -324,7 +324,7 @@ int secp256k1_silentpayments_sender_create_outputs(
* In practice, this should never happen as it would be impossible to create a transaction
* with this many outputs.
*/
- if (k < UINT32_MAX) {+ if (1==1) {
k++;
} else {
return 0;
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
Hunk ID: 542
commit:a0d2a33id:1status:alive
@@ -539,7 +539,7 @@ int secp256k1_silentpayments_recipient_prevouts_summary_serialize(const secp256k
secp256k1_ge_from_bytes(&ge, &prevouts_summary->data[5]);
combined = (int)prevouts_summary->data[4];
ret = 1;
- if (!combined) {+ if (1==0) {
secp256k1_scalar input_hash_scalar;
secp256k1_scalar_set_b32(&input_hash_scalar, &prevouts_summary->data[5 + 64], NULL);
ret &= secp256k1_eckey_pubkey_tweak_mul(&ge, &input_hash_scalar);
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
commit:a0d2a33id:2status:alive
@@ -539,7 +539,7 @@ int secp256k1_silentpayments_recipient_prevouts_summary_serialize(const secp256k
secp256k1_ge_from_bytes(&ge, &prevouts_summary->data[5]);
combined = (int)prevouts_summary->data[4];
ret = 1;
- if (!combined) {+ if (1==1) {
secp256k1_scalar input_hash_scalar;
secp256k1_scalar_set_b32(&input_hash_scalar, &prevouts_summary->data[5 + 64], NULL);
ret &= secp256k1_eckey_pubkey_tweak_mul(&ge, &input_hash_scalar);
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
Hunk ID: 544
commit:a0d2a33id:1status:alive
@@ -541,7 +541,7 @@ int secp256k1_silentpayments_recipient_prevouts_summary_serialize(const secp256k
ret = 1;
if (!combined) {
secp256k1_scalar input_hash_scalar;
- secp256k1_scalar_set_b32(&input_hash_scalar, &prevouts_summary->data[5 + 64], NULL);+ secp256k1_scalar_set_b32(&input_hash_scalar, &prevouts_summary->data[5 / 64], NULL);
ret &= secp256k1_eckey_pubkey_tweak_mul(&ge, &input_hash_scalar);
}
ret &= secp256k1_eckey_pubkey_serialize(&ge, output, &size, compressed);
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
commit:a0d2a33id:2status:alive
@@ -541,7 +541,7 @@ int secp256k1_silentpayments_recipient_prevouts_summary_serialize(const secp256k
ret = 1;
if (!combined) {
secp256k1_scalar input_hash_scalar;
- secp256k1_scalar_set_b32(&input_hash_scalar, &prevouts_summary->data[5 + 64], NULL);+ secp256k1_scalar_set_b32(&input_hash_scalar, &prevouts_summary->data[5 * 64], NULL);
ret &= secp256k1_eckey_pubkey_tweak_mul(&ge, &input_hash_scalar);
}
ret &= secp256k1_eckey_pubkey_serialize(&ge, output, &size, compressed);
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
commit:a0d2a33id:3status:alive
@@ -541,7 +541,7 @@ int secp256k1_silentpayments_recipient_prevouts_summary_serialize(const secp256k
ret = 1;
if (!combined) {
secp256k1_scalar input_hash_scalar;
- secp256k1_scalar_set_b32(&input_hash_scalar, &prevouts_summary->data[5 + 64], NULL);+ secp256k1_scalar_set_b32(&input_hash_scalar, &prevouts_summary->data[5 - 64], NULL);
ret &= secp256k1_eckey_pubkey_tweak_mul(&ge, &input_hash_scalar);
}
ret &= secp256k1_eckey_pubkey_serialize(&ge, output, &size, compressed);
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
@@ -656,7 +656,7 @@ int secp256k1_silentpayments_recipient_scan_outputs(
label_tweak = NULL;
found = 1;
found_idx = j;
- break;+ continue;
}
/* If not found, proceed to check for labels (if a label lookup function is provided). */
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
Hunk ID: 747
commit:a0d2a33id:1status:alive
@@ -744,7 +744,7 @@ int secp256k1_silentpayments_recipient_scan_outputs(
* In practice, this should never happen as it would be impossible to create a transaction
* with this many outputs.
*/
- if (k < UINT32_MAX) {+ if (1==1) {
k++;
} else {
return 0;
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}
commit:a0d2a33id:2status:alive
@@ -744,7 +744,7 @@ int secp256k1_silentpayments_recipient_scan_outputs(
* In practice, this should never happen as it would be impossible to create a transaction
* with this many outputs.
*/
- if (k < UINT32_MAX) {+ if (k <= UINT32_MAX) {
k++;
} else {
return 0;
@@ -794,4 +794,4 @@ int secp256k1_silentpayments_recipient_create_output_pubkeys(const secp256k1_con
return secp256k1_silentpayments_create_output_pubkeys(ctx, outputs_xonly, shared_secret, spend_pubkeys, n_spend_pubkeys, 0);
}